Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33447 )
Change subject: Documentation: Explain SimpleELF
......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
When I think of SELF documentation, I think of the stuff in https://review.coreboot.org/cgit/coreboot.git/tree/Documentation/cbfs.txt#n3..., which still has a lot more details about the actual format than you have here. Shouldn't this be integrated there instead?
The document hasn't been converted to markdown and won't show in our current documentation.
Looking at it, it's very technical and might not give a high level overview at first sight.
Once it has been converted to markdown I would reference it as 'in detail' documentation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia217af7d39505393ed9324fbe53b4ca7f3069e2e
Gerrit-Change-Number: 33447
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 14 Jun 2019 07:10:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment