Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35521 )
Change subject: [WIP] intel/pci: Utilise pci_def.h for PCI_BRIDGE_CONTROL ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35521/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/pci.c:
https://review.coreboot.org/c/coreboot/+/35521/1/src/southbridge/intel/bd82x... PS1, Line 78: dev->command |= PCI_COMMAND_IO; Hmm.. I think specs says VGA IO decode is enabled regardless of PCI_COMMAND_IO bit.
https://review.coreboot.org/c/coreboot/+/35521/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/pci.c:
https://review.coreboot.org/c/coreboot/+/35521/1/src/southbridge/intel/i8280... PS1, Line 77: dev->command |= PCI_COMMAND_IO; Hmm.. I think specs says VGA IO decode is enabled regardless of PCI_COMMAND_IO bit.