Attention is currently required from: Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Patrick Rudolph, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58602 )
Change subject: soc/intel/xeon_sp/cpu.c: Remove unused variables
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/58602/comment/6e327a4b_eee551c3
PS1, Line 204: intel_update_microcode_from_cbfs
This has an extra spinlock, does it matter?
right, that's a functional difference indeed... Anyway all microcode is already updated by this point anyway...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id809cd78fb9da98b9514fcf8d8057dccf2987d23
Gerrit-Change-Number: 58602
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 19:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment