Attention is currently required from: Bao Zheng, Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73910 )
Change subject: amdfwtool: Move some funtions to other source files ......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/signed_psp.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172156): https://review.coreboot.org/c/coreboot/+/73910/comment/8a9dcad4_751463e2 PS2, Line 217: S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH); Symbolic permissions 'S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH' are not preferred. Consider using octal permissions '0666'.