Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 )
Change subject: lib: Add fls() (Find Last Set)
......................................................................
Patch Set 4:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/59738/comment/36eeea12_ffebabeb
PS1, Line 137: fls
See CB:56543 as an example. Tests can be run by […]
I've created the unit tests for lib.h in CB:59834. Feel free to rebase this on top of that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 4
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 08:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment