Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier.
Jérémy Compostella has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86275?usp=email )
Change subject: drivers/intel/gma: Fix alignment of extended VBT in opregion
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/86275/comment/09a3f7dc_58f70a5c?usp... :
PS1, Line 337: opregion_size += ext_vbt_size;
Could you use a macro such as `ALIGN_UP` ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib3784eea6eb929ffec9672fc123b833c11c057e8
Gerrit-Change-Number: 86275
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 04 Feb 2025 17:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No