Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard
......................................................................
Patch Set 67: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-...
File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-...
PS61, Line 34: An external programmer is required
No idea where that policy comes from. […]
Done
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-...
File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-...
PS62, Line 34: An external programmer is required. You can just extract the SPI
mentioning programmers or flashrom commands is not helpful. Those should go into https://doc. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47d24ac8b236f929c3160f9a769b971d83710f9d
Gerrit-Change-Number: 33328
Gerrit-PatchSet: 67
Gerrit-Owner: Vlado Cibic
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vlado Cibic
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Jun 2019 14:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vlado Cibic
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment
