build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33162 )
Change subject: cpu: Add option to disable CPU AES ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig File src/cpu/Kconfig:
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@235 PS8, Line 235: code, you cannot be sure industrial or goverment's backdoors are silently trailing whitespace
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@239 PS8, Line 239: This is a serious risk for military or mission-critical devices. trailing whitespace
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@240 PS8, Line 240: trailing whitespace
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@241 PS8, Line 241: So, as hardware-accelerated AES are THE PERFECT location where to place a backdoor or trailing whitespace
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@242 PS8, Line 242: function hook to steal your keys, and many password managers/cryptography apps & libs trailing whitespace
https://review.coreboot.org/#/c/33162/8/src/cpu/Kconfig@243 PS8, Line 243: seem not to let the user to avoid AES, this option is a good way to mitigate the trailing whitespace