Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35463/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35463/11//COMMIT_MSG@48
PS11, Line 48: REAED32_BITFIELD(®, SEC_VIO)
READ32_BITFIELD
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h
File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h@...
PS11, Line 112: */
Should that also into the coding style documentation or something related, new developers can easily read?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 11
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Sep 2019 11:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment