Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... PS2, Line 9: COREBOOT_ID 0x40 : RO_FRID_PAD 0x780
Actually, no. […]
I share the opinion with Julius that if it really is a pure ID, than all boards should have it in the same manner. And from my point of view for such an ID there is no real need to have any address constraints so there is no real need to place it into a FMAP region, CBFS would serve the needs just fine. What I am not sure about is if we really should drop it completely. I use the git hash and mainboard name it contains every now and then to check an image I have read back from a flash. I still can find this information in console strings in the image but this is something that may change in the future and is a bit unhandy. So maybe we can agree on a ID format which is consistent for all boars with the same content all across the tree? And for me it would be fine to place it into the CBFS. The amount of flash space we need is little and should not lead to flash size issues. With this approach one could simply use cbfstool to get the content of this ID on an image if needed.