Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38694 )
Change subject: soc/amd/picasso: Move BERT region to cbmem ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38694/8/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/38694/8/src/soc/amd/picasso/Kconfig... PS8, Line 199: 8MB
Please update.
will do
https://review.coreboot.org/c/coreboot/+/38694/8/src/soc/amd/picasso/memmap.... File src/soc/amd/picasso/memmap.c:
https://review.coreboot.org/c/coreboot/+/38694/8/src/soc/amd/picasso/memmap.... PS8, Line 35: start = NULL;
Looks like a bug, are there more copies of this?
yes, this is a bug and it was copied from stoneyridge. fixed in 40506
https://review.coreboot.org/c/coreboot/+/38694/8/src/soc/amd/picasso/memmap.... PS8, Line 33: return (uintptr_t)cbmem_top();
Where is TSEG actually configured in the hardware? Is the same ALIGN_DOWN() […]
this code was copied from stoneyridge and will get removed in another patch in the picasso/mandolin patch train. this change was only to sort-of cleanly pull apart the pieces of this change from the other change