Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/...
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/...
PS9, Line 25: mmap_boot
It is still mmap_boot so it is technically correct.. You could just put a comment at the top. […]
That's a good idea. I will add a comment here and in mmap_boot.c to make it clear what the purpose of the file is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b564aed9809cf14b40a3b8e907622266fc782e2
Gerrit-Change-Number: 47659
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 01:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment