Hello Felix Singer, Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48418
to review the following change.
Change subject: [WIP] plot TxDQS ......................................................................
[WIP] plot TxDQS
Change-Id: I08677ee75826e1638142e221b4b5eedfd25f8b26 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48418/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index b0a75fc..f495d9d 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1738,6 +1738,17 @@ (tx_dqs % 32)) & 1); } } + + printk(BIOS_ERR, "channel %d rank %d results:\n", channel, slotrank); + printk(BIOS_ERR, "Delay\t01234567%c\n", ctrl->lanes == NUM_LANES ? '8' : ' '); + for (tx_dqs = 0; tx_dqs <= 128; tx_dqs++) { + printk(BIOS_ERR, "% 5d\t", tx_dqs); + FOR_ALL_LANES { + printk(BIOS_ERR, "%c", statistics[lane][tx_dqs] ? '#' : '.'); + } + printk(BIOS_ERR, "\n"); + } + FOR_ALL_LANES { struct run rn = get_longest_zero_run(statistics[lane], 128); /*