Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42733 )
Change subject: sb/amd/pi/hudson: Fixes for common GPIO API
......................................................................
Patch Set 11:
(1 comment)
haven't looked into the details yet, but i'm a bit surprised that this builds without SOC_AMD_COMMON_BLOCK_SMI being selected
https://review.coreboot.org/c/coreboot/+/42733/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42733/11//COMMIT_MSG@7
PS11, Line 7: sb/amd/pi/hudson: Fixes for common GPIO API
i find this a bit misleading; the commit adds the amd soc common gpio code to the build
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86ae40a3cdf335263d7e9e3dcfdd588947cdd9b1
Gerrit-Change-Number: 42733
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Dec 2020 16:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment