[coreboot-gerrit] Change in coreboot[master]: sb/intel/ibexpeak: Implement PCH function disable in chip_ops

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35753 )

Change subject: sb/intel/ibexpeak: Implement PCH function disable in chip_ops
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... 
File src/southbridge/intel/ibexpeak/pch.c:

https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... 
PS7, Line 36: if (pch_type < 0)
            : 		pch_type = pci_read_config8(dev, PCI_DEVICE_ID + 1);
            : 	return pch_type;
> It's still there on the latest patchset. What I'm not sure of is what the complexity with the "static int" is for

It's to avoid reading it again from PCI config space. OTOH this function is only called once so...