24 Feb
2020
24 Feb
'20
7:39 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39095 )
Change subject: superio/aspeed/ast2400: rename SWAK to SWC to match the datasheet ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39095/1/src/superio/aspeed/ast2400/... File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/c/coreboot/+/39095/1/src/superio/aspeed/ast2400/... PS1, Line 9: #define AST2400_SWC 0x4 /* System Wake-Up control */
Would keep it. In ASpeed spec: The device is named 'System Wake-Up Control (SWC)'. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/39095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b3a14946e37f805d1c4e3df343dfcd7f67f6dc8
Gerrit-Change-Number: 39095
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 18:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment