Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47291 )
Change subject: mb/google/volteer: Add new MAX98360_ALC5682I_I2S Audio option to FW_CONFIG
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47291/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47291/1//COMMIT_MSG@7
PS1, Line 7:
nit: "audio configuration"
Done
https://review.coreboot.org/c/coreboot/+/47291/1//COMMIT_MSG@7
PS1, Line 7:
nit: extra space
Done
https://review.coreboot.org/c/coreboot/+/47291/1//COMMIT_MSG@8
PS1, Line 8:
Something like this for a description: […]
Done, thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85bc37980957a3fb6c795858a4e4f44f3e3cc332
Gerrit-Change-Number: 47291
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Nov 2020 01:33:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment