David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37215 )
Change subject: pci_ids: Update Intel Lewisburg SMBUS PCI ID
......................................................................
Patch Set 5: Code-Review+2
Patch Set 5:
(8 comments)
Patch Set 5: Code-Review+1
Patch Set 1:
Though I will believe to rename to LBG will be better than LWB as that will match with Linux kernel.
I'd suggest using LBG if it's the official name
If everyone agrees, I can rename LWB to LBG. Or we will get this patch in, and do the rename in a sweep at a later time.
Agreed, let's do the sweep a later time and update all the instances of LWB at once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc0cb6f2f7eb337180c2ae89015953a9aeaed68b
Gerrit-Change-Number: 37215
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 20:32:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment