Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38763 )
Change subject: cpu/x86/smm: Add overflow check
......................................................................
Patch Set 1:
I am not sure if rest of the code survives if SMM stub is left uninstalled. I decided to abandon x86-smm-tseg topic now, but there are some static uses of IS_ENABLED(HAVE_SMI_HANDLER) that might take bad route. Maybe even die()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife26a0abed0ce6bcafe1e7cd8f499618631c4df4
Gerrit-Change-Number: 38763
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 10:26:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment