Attention is currently required from: Ravi kumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio ......................................................................
Patch Set 19:
(2 comments)
File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/3af6fda2_28212cfb PS19, Line 16: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);
This doesn't belong in this CL. Please create a separate CL for it.
This belongs in CL:50581
https://review.coreboot.org/c/coreboot/+/57449/comment/4e93c9a9_368940b7 PS19, Line 25: {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT), : "TPM interrupt"},
Same as above.
This belongs in CL:50581