Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... PS17, Line 107: y
If so, why would we not want to default to y, and just let any chromebooks that go against the norm of storing dram part number in CBI to override the behavior by setting it to "n" in their Kconfig?
Couple of reasons: 1. We support both MD(memory down) and SODIMM configurations. In the latter case, we don't really store DRAM part number in CBI. You can add "default y if HAVE_SPD_IN_CBFS" to ensure that this gets enabled for only those mainboards that have SPD in CBFS. But, we still have older boards which probably did not have DRAM part number in CBI.
2. If the mainboard really needs to provide its own implementation of this function for some reason. Example: CBI DRAM part number supported only after a certain build, etc. It provides flexibility to those boards.