Anna Karaś has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42313 )
Change subject: tests: Add lib/b64_decode-test test case ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c File tests/lib/b64_decode-test.c:
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c... PS1, Line 19: {"SGVsbG8h", "Hello!"}
nit: How about adding one with line breaks since the API explicitly supports that?
Done.
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c... PS1, Line 27: /* Provide necessary definition in order to satisfy dependencies. */
You may take a look here - https://review.coreboot. […]
I see that this commit has not been merged yet, so I decided to leave it as it is for now.
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c... PS1, Line 28: int do_printk(int msg_level, const char *fmt, ...) {
open brace '{' following function definitions go on the next line
Done.