Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41687 )
Change subject: mb/supermicro/x9scl: Select IPMI_KCS ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: -Code-Review
Patch Set 3: Code-Review-1
This is the X9SCL, not X9SCL-F which is a variant of X9SCL with BMC.
Supermicro provides multiple variants of each board, where the board itself matches but some components like BMC are missing: X9SCL = !BMC, X9SCL-F = BMC; X11SSM = !BMC, X11SSM-F = BMC
My suggestion on this one is to add the X9SCL-F as variant of X9SCL/X9SCM
I'll point out that Supermicro's firmware update image is identical for all of X9SCL, X9SCL-F, X9SCL+-F, X9SCM, X9SCM-F, X9SCM-iiF. I believe this holds true for the BMC firmware image (where applicable) too. I can probably figure out whatever GPIO pin or whatnot is used by the Supermicro firmware to differentiate boards with BMC from boards without.
If we find a way doing this, we should document somehow that BMC is detected automagically if present. Probably we also should rename the boards then: X9SCL(-F)/X9SCM(-F), X11SSM(-F)
Two possibilities are matching VGA pci device id or hardware id via superio (if we don't find a more generic way)