Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/i2c.c
File util/inteltool/i2c.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/i2c.c@45
PS6, Line 45: sunrise_i2c_registers
Maybe these registers for GSPI device?
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/i2c.c@60
PS6, Line 60: SPI_CS_CONTROL
SPI ???
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/i2c.c@199
PS6, Line 199: *(
See usb.c
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/thermal.c
File util/inteltool/thermal.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/thermal.c@16...
PS6, Line 163: *(
See usb.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 13:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment