Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43684 )
Change subject: cpu/x86/smm: SMM module loader version 2
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/Kconfig
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/Kconfig@129
PS2, Line 129: server
nit: maybe deemphasize the "server" mentions a bit? There are few non-server designs out there with more than 32 threads right now, but that may change over the next few years and nothing in here is strictly "server stuff".
https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/smm/smm_module_...
File src/cpu/x86/smm/smm_module_loaderv2.c:
https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/smm/smm_module_...
PS2, Line 123: not enough space in SMM to setup all CPUs
So how would a firmware developer start to solve this, or is SMM just not available on designs with too many threads?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00a23a5f2a46110536c344254868390dbb71854c
Gerrit-Change-Number: 43684
Gerrit-PatchSet: 2
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Reviewer: Eugene Myers
cedarhouse@comcast.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Jul 2020 17:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment