Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54078 )
Change subject: mb/google/mancomb: Update HUB_RST_L setting in GPIO ......................................................................
mb/google/mancomb: Update HUB_RST_L setting in GPIO
Configure USB HUB_RESET_L gpio to high.
BUG=b:187485847 TEST=Build and boot from USB to OS, check the USB function.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I94e4806c7463030df31f8d819510f9533a622f2a Reviewed-on: https://review.coreboot.org/c/coreboot/+/54078 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/mancomb/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/mancomb/variants/baseboard/gpio.c b/src/mainboard/google/mancomb/variants/baseboard/gpio.c index f829117..5ccbc10 100644 --- a/src/mainboard/google/mancomb/variants/baseboard/gpio.c +++ b/src/mainboard/google/mancomb/variants/baseboard/gpio.c @@ -51,7 +51,7 @@ /* AC_PRES */ PAD_NF(GPIO_23, AC_PRES, PULL_UP), /* HUB_RST_L */ - PAD_GPO(GPIO_24, LOW), + PAD_GPO(GPIO_24, HIGH), /* GPIO_25: Not available */ /* TODO: change back to PCIE_RST_L when we figure out why PCIE_RST doesn't go high. */ PAD_GPO(GPIO_26, HIGH),