Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35802 )
Change subject: soc/intel/cannonlake: Add debugging of a number of FSPM parameters ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35802/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35802/4//COMMIT_MSG@9 PS4, Line 9: This implements soc_display_fspm_upd_params for soc/intel/cannonlake Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/35802/4//COMMIT_MSG@15 PS4, Line 15: How much do these string increase the image size?
https://review.coreboot.org/c/coreboot/+/35802/4/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35802/4/src/soc/intel/cannonlake/ro... PS4, Line 146: const FSPM_UPD *fspm_new_upd) Fits into 96 characters.
https://review.coreboot.org/c/coreboot/+/35802/4/src/soc/intel/cannonlake/ro... PS4, Line 155: printk(BIOS_SPEW, "UPD values for MemoryInit:\n"); There is a Kconfig value for debugging RAM init, I believe.