Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41884/10/src/drivers/intel/dptf/dpt...
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/10/src/drivers/intel/dptf/dpt...
PS10, Line 95: /* The CPU device gets an _ADR that matches the ACPI PCI address for 00:04.00 */
: parent = dev && dev->bus ? dev->bus->dev : NULL;
: if (!parent || parent->path.type != DEVICE_PATH_PCI) {
: printk(BIOS_ERR, "%s: DPTF objects must live under 00:04.0 PCI device\n",
: __func__);
: return;
: }
acpigen_write_ADR_pci_device asserts that the device is of type PCI. […]
Also to make sure that the `chip drivers/intel/dptf` is placed under at least a PCI device 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief69a57adce9ee0b19056ce6a11ed8a5b51b3f87
Gerrit-Change-Number: 41884
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 02:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment