Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: ACPI code for Apple MacBooks ......................................................................
Patch Set 5:
(3 comments)
Rewritten with new syntax, tested again on MBA 5,1.
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl File src/ec/apple/acpi/battery.asl:
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl@3 PS2, Line 3: *
missing copyright
Done
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl@17 PS2, Line 17: SPTR, 8,
to many tabs
Done
https://review.coreboot.org/#/c/33102/5/src/ec/apple/acpi/battery.asl File src/ec/apple/acpi/battery.asl:
https://review.coreboot.org/#/c/33102/5/src/ec/apple/acpi/battery.asl@147 PS5, Line 147: Local0++ & 0xFFFF I have doubts about this, is this correct? It was `And(Increment(Local0), 0xFFFF, Local0)`