Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )
Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Please keep compability with old DIMMs
I agree, but the manufacture id table itself is not backward compatible, so any suggestion here? Worst case the 0xff2c for Micron is not correct I believe.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
Gerrit-Change-Number: 32837
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 May 2019 16:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment