Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37643 )
Change subject: Documentation: Add proposal for firmware testing ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 46: *
nit: can we make this **bold** instead of *italic*; I think it would be easier to read. […]
Done
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 58: must allow to specify DUTs and
nit: must allow DUTs to specify […]
that... depends... I was thinking of having the management side know about the DUTs' properties. While the DUTs could report that for themselves, such an approach requires the DUTs to be functional enough to state that. So if anything I'd see this as a confirmation thing (serialtest claims $set_of_properties, DUT disagrees -> failure).
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 134: The test system will be implemented in Go:
Are we also going to adopt Golang's table driven test methodology? https://github. […]
That seems to be rather limited and mostly suitable for unit tests (where you want to check that a=f(b) holds true for a set of a,b pairs)
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 139: The build creates a host side test runner (native OS/arch) and a : variable number of DUT test runners (for all supported DUT OS/arch : pairs) that are provided to the DUT on some storage medium (e.g. USB : stick). In a fully automated environment this might require switching : USB ports between host and DUT.
are we going to use https://github. […]
I was looking into option for TAP and I think this one came up, yes. Added after requirement 10.
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 173: dita
is this supposed to render as something in gitiles? […]
These documents are rendered to doc.coreboot.org which has support for ditaa. The advantage of this is that people without rendering get a useful approximation in the form of ascii art.
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 203: no
not
Done
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 203: solution
soultions
Done