build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Support to initialize Memory ......................................................................
Patch Set 8:
(16 comments)
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 233: static void read_smbus_spd(struct spd_block *blk, size_t *spd_len, uintptr_t *data0, uintptr_t *data1) line over 96 characters
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 236: get_spd_smbus(blk); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 236: get_spd_smbus(blk); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 237: *spd_len = blk->len; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 237: *spd_len = blk->len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 238: *data0 = (uintptr_t)blk->spd_array[0]; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 238: *data0 = (uintptr_t)blk->spd_array[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 239: *data1 = (uintptr_t)blk->spd_array[2]; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 239: *data1 = (uintptr_t)blk->spd_array[2]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 276: * 16 bits denoting DQ_PER_CHANNEL please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 280: for(unsigned int i=0; i<DDR4_CHANNELS; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 280: for(unsigned int i=0; i<DDR4_CHANNELS; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 280: for(unsigned int i=0; i<DDR4_CHANNELS; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 281: for(int b=0; b<DQ_SODIMM_SLOT; b++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 281: for(int b=0; b<DQ_SODIMM_SLOT; b++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/8/src/soc/intel/tigerlake/mem... PS8, Line 281: for(int b=0; b<DQ_SODIMM_SLOT; b++) { space required before the open parenthesis '('