[coreboot-gerrit] Change in coreboot[master]: WIP: inteltool: Add option to output GPIOs as coreboot macros

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39394 )

Change subject: WIP: inteltool: Add option to output GPIOs as coreboot macros
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... 
File util/inteltool/gpio_groups.c:

https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... 
PS1, Line 68: static const char *decode_table_gpio_reset(const size_t reset)
> I get mismatching output, comparing Maxim's go approach an this patch. […]

yep, this is wrong. You have to take the reset mapping into account. See reset_mapping_rst_map in src/soc/intel/*/gpio.c