Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38748 )
Change subject: soc/intel/common/block/lpc: Add support to allow all UART options ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38748/1/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/38748/1/src/soc/intel/common/block/... PS1, Line 17: prompt "Index for COMA UART" Why the prompt? Doesn't this depend on devicetree or static hardware settings?
If there is no reason for a prompt, such options should be part of the devicetree (or just be derived from the existing devicetree information at runtime).
https://review.coreboot.org/c/coreboot/+/38748/1/src/soc/intel/common/block/... PS1, Line 18: DRIVERS_UART_8250IO I know it's probably derived from line 8, but I don't understand it... DRIVERS_UART_8250IO is about the driver coreboot uses for its console.