Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS ......................................................................
Patch Set 6:
(3 comments)
Just some nits on description. Thanks!
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG@11 PS6, Line 11: so we want to replace by $(<) and need to quote it by an extra '$'. so we should quote it by an extra '$' or use the arg ($1 or $2) directly.
Also, $(@)=$2 is actually a temporary file and what we want is the source file so using $1 is more correct.
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG@18 PS6, Line 18: ** $$(@) == $(2) ** $1 contains the name of source file.
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG@19 PS6, Line 19: $$(@) $1