Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: console: Override coreboot log level via VPD variable ......................................................................
Patch Set 4: Code-Review+1
Patch Set 4:
The design with `CONSOLE_OVERRIDE_LOGLEVEL` looks a little strange. Can’t it be implemented the same as NVRAM/CMOS (User Option Table)? If VPD is selected, always check for the log level setting in VPD.
Not all users of VPD store the log level in VPD. And I think NVRAM/CMOS wouldn't a good idea, because that can't be updated through the BMC interface (on OCP servers).
Implementing the API like the one used for CMOS doesn't imply to use CMOS...
I agree that CONSOLE_OVERRIDE_LOGLEVEL is just an odd hack and obviously doesn't scale (one can't mix override implementations). It would be better to unify option APIs. Trying to say it differently: nobody said that `get_option(..., "debug_level");` can only query CMOS.
Good idea. Thank you for saying it crystal clear.