Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46460 )
Change subject: soc/intel: drop unneeded ISST configuration code ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46460/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46460/4//COMMIT_MSG@10 PS4, Line 10: (de) Just `activate` would be more accurate as the system is always supposed to start with HWP disabled.
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG@16 PS6, Line 16: OS to not enable HWP if that is desired. Please also mention the other bits that were set by the dropped code. AFAIR, you confirmed that they are set by default on one unit. We should test that on some more (as datasheets pretend they are 0 by default). Make sure to always test a cold boot, the bits may be sticky.
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG@19 PS6, Line 19: , as well as the devicetree option I don't see that.
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG@21 PS6, Line 21: explicitly disabling Are there any?