View Change
4 comments:
Commit Message:
Patch Set #4, Line 10: (de)
Just `activate` would be more accurate as the system is always
supposed to start with HWP disabled.
Commit Message:
Patch Set #6, Line 16: OS to not enable HWP if that is desired.
Please also mention the other bits that were set by the dropped
code. AFAIR, you confirmed that they are set by default on one
unit. We should test that on some more (as datasheets pretend
they are 0 by default). Make sure to always test a cold boot, the
bits may be sticky.
Patch Set #6, Line 19: , as well as the devicetree option
I don't see that.
Patch Set #6, Line 21: explicitly disabling
Are there any?
To view, visit change 46460. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I952720cf1de78b00b1bf749f10e9c0acd6ecb6b7
Gerrit-Change-Number: 46460
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 21 Oct 2020 17:16:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment