build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35463/8/src/include/device/mmio.h
File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/8/src/include/device/mmio.h@9...
PS8, Line 91: #define DEFINE_BITFIELD(name, high_bit, low_bit) \
Macros with multiple statements should be enclosed in a do - while loop
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 08:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment