Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33941 )
Change subject: soc/intel/cannonlake: Fix PMC and GPIO block values for PCH-H
......................................................................
Patch Set 7: -Code-Review
(1 comment)
https://review.coreboot.org/#/c/33941/7/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/gpio_soc_defs_cnp_h.h:
https://review.coreboot.org/#/c/33941/7/src/soc/intel/cannonlake/include/soc...
PS7, Line 26: * please do not modify them.
Sorry, missed that you also added a comment here. These values
are correct in the datasheet, afaics.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ecc9552468037598ef5d4e10122d660dcbfe71d
Gerrit-Change-Number: 33941
Gerrit-PatchSet: 7
Gerrit-Owner: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Jul 2019 18:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment