Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: [WIP] soc/amd/common: Access ACPI MMIO via proper symbols ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Haven't looked at it in detail, but I think it's a good approach.
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/ac... PS4, Line 28: Indent is off
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/in... PS4, Line 42: Damn, Remove the swear