[coreboot-gerrit] Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@2 
PS1, Line 2: perezpri
> Please use your full name.

Ack

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet: Adding CNL ISH Device ID for PCI driver.
> Please remove the dot/period at the end of the commit message summary.

Ack

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet
> Prefixes are often lowercase. […]

Using SOC name instead.

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Adding
> Imperative mood: Add

Ack