Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY ......................................................................
Patch Set 5:
(6 comments)
File src/soc/amd/cezanne/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/531e4d1e_17b4d5a9 PS5, Line 79: uint8_t usb_phy_custom; please, no space before tabs
File src/soc/amd/cezanne/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/7c0be774_34f0b6f3 PS5, Line 131: if(config->usb_phy_custom) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/04bfa020_6bd43166 PS5, Line 131: if(config->usb_phy_custom) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/1f01606e_34d8496b PS5, Line 132: mcfg->usb_phy=(struct usb_phy_config *) &config->usb_phy; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/772acab6_6f19f0ba PS5, Line 133: else suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119268): https://review.coreboot.org/c/coreboot/+/54065/comment/161b698f_84217127 PS5, Line 134: mcfg->usb_phy=NULL; spaces required around that '=' (ctx:VxV)