Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 )
Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1...
PS8, Line 89: register "wait_for_bmc" = "1"
Is it necessary to wait for full BMC init for super I/O to work?
As far as I can see it's not. Did not realize that it is not necessary for the BMC to work. Will be removed in the next patch set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70
Gerrit-Change-Number: 34905
Gerrit-PatchSet: 8
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 15:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment