Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38368 )
Change subject: sb/intel/i82371eb: Enable upper NVRAM bank
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38368/1/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38368/1/src/southbridge/intel/i8237...
PS1, Line 67: RTC_POS_DECODE | UPPER_RAM_EN | RTC_ENABLE);
Fits on the previous line (we switched to 96 characters not too long ago)
Done
https://review.coreboot.org/c/coreboot/+/38368/1/src/southbridge/intel/i8237...
PS1, Line 68:
Empty line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad127ca4394e27fc055ddf03012a195cb03bd94
Gerrit-Change-Number: 38368
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 12 Jan 2020 02:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment