22 Apr
2019
22 Apr
'19
5:43 p.m.
Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32367 )
Change subject: mb/google/sarien: Fix s5 touchscreen power leakage ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants... PS4, Line 21: 5
I know we've been focusing on S0ix and S5 power, but should this also be done in S3?
S3 is not a POR on both sarien and arcada.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4229477b7149c0a75f4a8c6c7c453a37cc1c78c
Gerrit-Change-Number: 32367
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Roy Mingi Park roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Apr 2019 17:43:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment