Attention is currently required from: Raul Rangel, Furquan Shaikh, Yu-hsuan Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55029 )
Change subject: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c:
https://review.coreboot.org/c/coreboot/+/55029/comment/80e37516_0a873474
PS1, Line 73: _WOV
Is it safe to expose this as 0 for older platforms too? e.g. Picasso.
For Picasso, dmic_select_gpio is configured and so this method will return 1 there too. But I am not sure, if it should return 1 or 0 in previous SoC generation. I can check with audio experts and update the code accordingly here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide84f45f5ea2ae42d5efe71ac6d1595886157045
Gerrit-Change-Number: 55029
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Comment-Date: Thu, 27 May 2021 23:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment