Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44155 )
Change subject: sb/intel/lynxpoint: Consider root ports being disabled by strap ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44155/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/44155/2/src/southbridge/intel/lynxp... PS2, Line 108: * +-----+----+----+----+----+ : * | RPC | #5 | #6 | #7 | #8 | : * +-----+----+----+----+----+ : * | 0 | x1 | x1 | x1 | x1 | : * | 1 | x2 | | x1 | x1 | : * | 2 | x2 | | x2 | | : * | 3 | x4 | | | | : * +-----+----+----+----+----+ The datasheet (328904-003) only states something about port 1-4 about this. Maybe add a comment that this applies to port 5-8 too?