Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32853 )
Change subject: soc/intel/cannonlake: Fill DIMM serial number from SPD
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32853/2/src/soc/intel/cannonlake/romstage/ro...
File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/#/c/32853/2/src/soc/intel/cannonlake/romstage/ro...
PS2, Line 117: Extract serial number from SPD
looks like this SpdSave is not unique to cannonlake so I'll add this to dimm_info_fill() and fix the others.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85438bd1d581095ea3482dcf077a7f3389f1cd47
Gerrit-Change-Number: 32853
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 17 May 2019 21:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment