Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )
Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324
......................................................................
Patch Set 3:
(1 comment)
Would you help review the CL based on result https://partnerissuetracker.corp.google.com/issues/161759253#comment23 ?
Thank you.
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v...
PS2, Line 10: bid_1_gpio_set_stage_ram
I will discuss that with our hardware team and update result later.
The schematic about p sensor will not be modified for board version 2+.
Therefore, the gpio is configured in vilboz_gpio_set_stage_ram.
I will create another issue to track and update the rest gpios between board version 1 and 2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889
Gerrit-Change-Number: 45565
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 08:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu
frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment